Update for latest versions of Cordova and cordova-android #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@codinronan You're welcome, it was a necessity fix for a project I was working on and did not yet have time to fully test it and create a PR myself, thanks for the PR (and check/support)... |
|
Just merged into master. will release to npm after giving it a final test. |
|
@kelvinhokk thanks! I just realized I missed the plugin.xml file, can you bump that one too if you are going to do an NPM release? |
|
@kelvinhokk Awesome! 🏆 We've tested it and it works great. Any chance you'll be able to release an update to NPM? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there,
This isn't my work, all credit goes to https://github.com/chancezeus/cordova-plugin-localization-strings, I just don't like having to npm install from custom forks! So I am hoping we can get his awesome work merged back up into the primary project.
Thanks @chancezeus!