Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign team cards to display all at once. #chore : (remove carousel) #38

Closed
kelvinkamau opened this issue Feb 25, 2019 · 4 comments
Closed

Redesign team cards to display all at once. #chore : (remove carousel) #38

kelvinkamau opened this issue Feb 25, 2019 · 4 comments
Assignees
@stellakaniaru

Comments

@kelvinkamau
Copy link
Owner

No description provided.

@pbrahmbhatt3
Copy link

Hi,

I would like to work on it. Can you provide me some more information about this issue?

@kelvinkamau
Copy link
Owner Author

Hello @pbrahmbhatt3
Feel free to go for it

More info

Steps

  • Fork project
  • Clone to local machine
  • Make changes to section
    • Remove entire section
    • Replace it following the mockup below
  • Push code for review

Final UI should look exactly like this

teamdemo

@kelvinkamau kelvinkamau transferred this issue from kelvinkamau/Vibranium Apr 7, 2019
@pbrahmbhatt3
Copy link

@kelvinkamau I have solved this issue and created a pull request. Can you please have a look at it? Thank you

@stellakaniaru
Copy link
Collaborator

Hey @pbrahmbhatt3
The PR you submitted was dealing with issue #40. It has been reviewed.
This one looks at redesigning the team cards, as @kelvinkamau described above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stellakaniaru stellakaniaru

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stellakaniaru @kelvinkamau @pbrahmbhatt3