New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deque in Go #211
Add deque in Go #211
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @leandronsp, could you please add package main
and apply gofmt
My bad, I forgot to apply |
@kelvins it seems that the testify package is making the lint phase fail. I'll remove the testify and rewrite the tests following other go files in this project, I'll work on that in the next couple of days |
Otherwise, do you think it's a good idea adding testify assert to the pipeline? I think it helps writing good tests in Go. But I'm okay in case you think we should not use it for now |
I agree that testify is a great library for performing assertions, but since this repository is intended for study purposes, I suggest avoiding any kind of external library. Using external libraries would make it difficult for newcomers to contribute, it would be hard to run the code online (like in playgrounds) and harder to maintain (to keep library versions updated). I would suggest implementing tests using the standard library or implementing a |
okay @kelvins , I'll apply the adjustments and update the PR, thanks |
up @kelvins |
This PR adds an implementation in Go for Deque (double-ended queue).
It covers some test scenarios using the library testify which makes easier to write unit tests in Go.