Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GeocodingReverseIntl #3

Merged
merged 1 commit into from Jan 13, 2020
Merged

Add GeocodingReverseIntl #3

merged 1 commit into from Jan 13, 2020

Conversation

corporateanon
Copy link

Allows to perform make geocoding in local languages

@coveralls
Copy link

Coverage Status

Coverage decreased (-28.6%) to 61.979% when pulling 455d3f6 on corporateanon:master into 8464fc2 on kelvins:master.

@kelvins
Copy link
Owner

kelvins commented Jan 13, 2020

Thanks for the contribution, the tests are failing because of the API key. I'm not 100% sure but I believe some time ago we could perform a few requests without an API key (this is why the tests were passing). It would be great to figure out a way to mock this API calls to run the tests, but this is something to another PR.

@kelvins kelvins merged commit a8a966a into kelvins:master Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants