Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Crystal v0.30.0 #548

Merged
merged 1 commit into from
Aug 3, 2019
Merged

Conversation

bcardiff
Copy link
Contributor

A Crystal::VERSION check should be added if you want kemal to be warning free but also keep working in 0.29.0.

You can double check in crystal-lang/crystal#7997 which encode/decode method apply better for each situation.

Copy link
Member

@sdogruyol sdogruyol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @bcardiff 🙏

@sdogruyol sdogruyol merged commit 17bf1c7 into kemalcr:master Aug 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants