Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump exception_page dependency #669

Merged
merged 4 commits into from Jan 23, 2024
Merged

Bump exception_page dependency #669

merged 4 commits into from Jan 23, 2024

Conversation

Sija
Copy link
Contributor

@Sija Sija commented Dec 27, 2023

Description of the Change

  • Bumps exception_page shard version to ~> 0.4.1, which includes syntax highlighting and tweaked UX.
  • Fixes Ameba issues, which makes CI 馃挌 again
  • Fixes Crystal deprecation warning

@Sija
Copy link
Contributor Author

Sija commented Dec 27, 2023

@sdogruyol ping

shard.yml Outdated Show resolved Hide resolved
Co-authored-by: Johannes M眉ller <straightshoota@gmail.com>
@Sija Sija changed the title Bump exception_page to v0.4.0 Bump exception_page dependency Dec 27, 2023
@Sija
Copy link
Contributor Author

Sija commented Jan 1, 2024

@straight-shoota @sdogruyol new year's ping

@Sija
Copy link
Contributor Author

Sija commented Jan 10, 2024

Hello?

@Sija Sija mentioned this pull request Jan 10, 2024
Copy link
Member

@sdogruyol sdogruyol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @Sija 馃檹

@sdogruyol sdogruyol merged commit 9628043 into kemalcr:master Jan 23, 2024
4 checks passed
@Sija Sija deleted the patch-3 branch January 23, 2024 16:11
@Sija
Copy link
Contributor Author

Sija commented Jan 30, 2024

@sdogruyol Could we have a new minor version release?

@Sija
Copy link
Contributor Author

Sija commented Feb 14, 2024

@sdogruyol ping 鈽濓笍

@sdogruyol
Copy link
Member

@Sija actually waiting for the new Crystal release 馃

@Sija
Copy link
Contributor Author

Sija commented Feb 14, 2024

@sdogruyol Any particular reason to do so?

@sdogruyol
Copy link
Member

@Sija sure, to release a major kemal version according with a major crystal release

@Sija
Copy link
Contributor Author

Sija commented Feb 14, 2024

There's no need for a major release given the amount of changes made. Also, what's the point of synchronization of releases between Crystal and Kemal?

@sdogruyol
Copy link
Member

@Sija it's been always like that for the last 9 years...you're the first person to ask the question. I see your point 馃憤

@Sija
Copy link
Contributor Author

Sija commented Feb 14, 2024

Sure, maybe I missed something yet as I mentioned before, there's no need for a major release.

@Sija
Copy link
Contributor Author

Sija commented Feb 14, 2024

Also, out of curiosity, what's the motivation for synchronization like that? I know you've mentioned it as a sort of "tradition", yet I'm failing to grasp the rationale behind it. From my perspective it's just superficial constraint unnecessary slowing the release cycle.

@sdogruyol
Copy link
Member

@Sija like I said, it's been always like that...I'll start to release more often 馃憤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants