consistent locations for cache and configuration files #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed explicit use of sqlite to vacuum the cache file; requests-cache does that itself as of 0.5.1.
|
I'm generally for this, but I think if the cache is getting moved somewhere less-visible it'd probably be good to add an explicit call to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This establishes consistent locations for the configuration and cache files instead of looking for them in whatever the current working directory happens to be.
It makes use of AppDirs to pick appropriate places.
To avoid directly interacting with the request cache by filename, this patch removes explicit use of sqlite to vacuum the cache file; requests-cache does that itself as of 0.5.1.