Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR against Skeleton? #3

Closed
mshick opened this issue Dec 16, 2014 · 4 comments
Closed

PR against Skeleton? #3

mshick opened this issue Dec 16, 2014 · 4 comments
Labels

Comments

@mshick
Copy link

mshick commented Dec 16, 2014

Perhaps you'd be interested in doing a PR against Skeleton and working with @dhg to get Skeleton on npm with this functionality (and at this name). Might make things clearer for the community.

See: dhg/Skeleton#190

@kenany
Copy link
Owner

kenany commented Dec 17, 2014

@mshick Whoops, didn't notice that PR :) Anyways yeah I can add @dhg as an owner of this package (for the name of course) on npm when he creates an account and then he can take the reins from there. It'd be cool if I could still require('skeleton.css') to get the entire stylesheet though.

@mshick
Copy link
Author

mshick commented Dec 17, 2014

I agree. Perhaps you can do a PR with the index.js and the updated package.json once @dhg gets things published?

I mean, ultimately it's his call -- maybe he'd prefer not messing with npm at all, in which case I'll definitely use your package.

On Dec 16, 2014, at 11:47 PM, Kenan Yildirim notifications@github.com wrote:

@mshick Whoops, didn't notice that PR :) Anyways yeah I can add @dhg as an owner of this package (for the name of course) on npm when he creates an account and then he can take the reins from there. It'd be cool if I could still require('skeleton.css') to get the entire stylesheet though.


Reply to this email directly or view it on GitHub.

@kenany
Copy link
Owner

kenany commented Dec 17, 2014

@mshick I think we can still do everything from dhg/Skeleton#190. If you give me commit access to your fork, I can push a commit which adds the index.js (this is all assuming @dhg is up for such a thing). Then dhg/Skeleton#190 will have both your commit which adds the package.json and my commit with adds the index.js. We can amend your commit to update the package.json to update the "name", "files", and "devDependencies".

@mshick
Copy link
Author

mshick commented Dec 19, 2014

Cool, added. Go ahead!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants