Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UUID and LUID types to InfoType #14

Closed
kenba opened this issue Oct 15, 2021 · 1 comment
Closed

Add UUID and LUID types to InfoType #14

kenba opened this issue Oct 15, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@kenba
Copy link
Owner

kenba commented Oct 15, 2021

OpenCL 3 can use the values: CL_DEVICE_UUID_KHR, CL_DRIVER_UUID_KHR and CL_DEVICE_LUID_KHR in calls to clGetDeviceInfo to get UUID and LUID values from OpenCL 3 devices. A UUID is a 16 byte array and a LUID is an 8 byte array.

Currently, UUIDs and LUIDs are both returned as Vec of the equivalent size and can be converted into Uuid an Luid types defined in device.rs. However, it would be more consistent if the Uuid an Luid types were values of the InfoType enum instead of newtypes in device.rs.

It would also be an opportunity to fix the bug in fmt::Display for Uuid!

@kenba kenba added the enhancement New feature or request label Oct 15, 2021
@kenba kenba self-assigned this Oct 15, 2021
@kenba
Copy link
Owner Author

kenba commented Oct 15, 2021

Incorporated in version 0.6.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant