Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change InfoType to handle nulls in strings returned from OpenCL devices #2

Closed
kenba opened this issue Mar 18, 2021 · 2 comments
Closed

Change InfoType to handle nulls in strings returned from OpenCL devices #2

kenba opened this issue Mar 18, 2021 · 2 comments
Assignees
@kenba
Labels
enhancement New feature or request

Comments

@kenba
Copy link
Owner

kenba commented Mar 18, 2021

@vmx has raised an issue (opencl3 #8) which is very similar to #1 raised by @jsatka.

There is clearly an issue with some OpenCL devices returning invalid CStrings in response to calling clGetProgramBuildInfo with CL_PROGRAM_BUILD_LOG and probably in other circumstances too.

The cl3 and opencl3 libraries should be resilient to such issues. Therefore, InfoType should be changed to make it easier to handle invalid CStrings from the OpenCL API in the opencl3 library.
@kenba kenba added the enhancement New feature or request label Mar 18, 2021
@kenba kenba self-assigned this Mar 18, 2021
kenba added a commit that referenced this issue Mar 18, 2021
@kenba
Change InfoType to_str handling for #2.
fdbf953 
Remove `Str` enum value, use `VecUchar` instead.
Add `to_str_unchecked` method to convert a  `VecUchar` into a `CString` including all `nul` characters.
@kenba kenba mentioned this issue Mar 18, 2021
Closed
@vmx
Copy link
Contributor

vmx commented Mar 19, 2021

I left a comment on the commit fdbf953#r48442244

kenba added a commit that referenced this issue Mar 19, 2021
@kenba
Remove to_str_unchecked() for issue #2
6c83ac3
kenba added a commit that referenced this issue Mar 19, 2021
@kenba
Convert remaining nulls to spaces in to_str for issue #2
6e9853c
@kenba
Copy link
Owner Author

kenba commented Mar 19, 2021

Fix incorporated in cl3 crate version 0.1.7.

@kenba kenba closed this as completed Mar 19, 2021
@kenba kenba mentioned this issue Mar 21, 2021
Merged
@kenba kenba mentioned this issue Sep 20, 2021
Closed
@kenba kenba mentioned this issue Oct 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kenba kenba

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vmx @kenba