Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Declare OpenCL release_* and retain_* functions unsafe #25

Closed
kenba opened this issue Aug 9, 2022 · 1 comment
Closed

Declare OpenCL release_* and retain_* functions unsafe #25

kenba opened this issue Aug 9, 2022 · 1 comment
Assignees
@kenba

Comments

@kenba
Copy link
Owner

kenba commented Aug 9, 2022

The OpenCL release_* and retain_* functions alter the OpenCL C library's object reference counters, this can lead to undefined behaviour when called from the opencl3 library objects, see kenba/opencl3#51.

The svm_free function is also declared unsafe as it invalidates SVM pointers.
@kenba kenba self-assigned this Aug 9, 2022
kenba added a commit that referenced this issue Aug 9, 2022
@kenba
Declare functions unsafe for issue #25
321e4ff
@kenba kenba mentioned this issue Aug 9, 2022
Closed
@kenba
Copy link
Owner Author

kenba commented Sep 10, 2022

Changes published to crates.io.

@kenba kenba closed this as completed Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kenba kenba

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kenba