Feat/delivery time edge case #11

kenchoong · 2022-10-24T13:16:01Z

Summary

Change algorithm of getPackageComboPerTrip, using Improper subset method, to cover the edge cases (Some high level thinking here)
Helper method decideSendFirstCombo and test cases
Helper method getPackageComboSequence and test cases
Use getPackageComboSequence in DeliveryTimeService file
Remove comment in DeliveryTimeService
Add more test case in DeliveryTimeService to cover edge case
Create separate mock file for better reusability in multiple test case and easier to work in IDE

Mainly solve this reported issue: #10

function and test case

and test case, and reusuable in multiple test case

and test case for all the possible edge case

and test case, separate the operation from service method

remove some comment in code

kenchoong added 8 commits October 24, 2022 20:57

feat(delivery-time): decide which package combo should send first

92a096e

function and test case

test(delivery-time): mocked input for different situation

b9f05b6

and test case, and reusuable in multiple test case

fix(delivery-time): getPackageComboPerTrip edge case algorithm

c9474d4

and test case for all the possible edge case

feat(delivery-time): getPackageComboSequence

9966749

and test case, separate the operation from service method

feat(delivery-time): move some operation to separate file

b8432ec

remove some comment in code

test(delivery-time): add test case for edge cases

35354ed

test(delivery-time): recover the test case

d848d3e

test(delivery-time): test case to cover all situation

1e54b69

kenchoong mentioned this pull request Oct 24, 2022

Edge case for Delivery Time estimation #10

Closed

kenchoong added 2 commits October 25, 2022 00:17

build(courrier-service): add jest clear cache command

c8de71b

docs(courrier-service): update readme

9384a10

kenchoong merged commit fe86b6e into master Oct 24, 2022

Provide feedback