Add "types" to package exports for TypeScript NodeNext #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TypeScript 4.7 has support for package exports, however it requires that each package export entry specifies the typings for that export. If omitted, for a project that is using the new `NodeNext` resolution mode, the typings will not be found: https://devblogs.microsoft.com/typescript/announcing-typescript-4-7/#package-json-exports-imports-and-self-referencing This PR adds a "types" field to the two export conditions, so that they can be imported when using the `NodeNext` setting in TypeScript 4.7.
|
Thanks for the patch @aomarks - the tests pass so I am going to merge this. |
|
Published 5.0.4 to NPM https://www.npmjs.com/package/urlpattern-polyfill/v/5.0.4 |
Thanks for the super fast review and publish! Much appreciated. It looks like for some reason the https://unpkg.com/browse/urlpattern-polyfill@5.0.4/dist/index.d.ts |
|
That is very strange, not sure how that could be @SanderElias ? |
Confirmed, it's compiling nicely for us now. Thanks again! |
aomarks
added a commit
to lit/lit
that referenced
this pull request
Jul 15, 2022
- Upgrades almost all dependencies, both dev and prod.
- There were only 2 deps I didn't tackle in this PR, because it seems like they'll need a little more work:
- parse5 6 -> 7 (cc @43081j, seems like the types API is substantially different now, so I wasn't able to easily do this upgrade).
- react 17 -> 18 (cc @justinfagnani @taylor-vann I wasn't sure what the implications/requirements for upgrading to react 18 will be, so I didn't even try).
- Consolidated some very common devDeps (e.g. uvu, mocha) into the top-level package.json, for easier future upgrade.
- Removes some unnecessary dependencies I found.
- Updates a few spots where typings changed.
- Removes 350MB (1.6GB -> 1.25GB) and 999 packages (3122 -> 2123), from our install.
- FYI these external PRs were also needed to get things fully upgraded:
- kenchris/urlpattern-polyfill#101
- google/tachometer#239
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeScript 4.7 has support for package exports, however it requires that each package export entry specifies the typings for that export. If omitted, for a project that is using the new
NodeNextresolution mode, the typings will not be found: https://devblogs.microsoft.com/typescript/announcing-typescript-4-7/#package-json-exports-imports-and-self-referencingThis PR adds a "types" field to the two export conditions, so that they can be imported when using the
NodeNextsetting in TypeScript 4.7.It also adds a
.jsextension toindex.d.ts's import oftypes, which is also required when consumers are using the newNodeNextresolution mode.