Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force the username to lowercase #90

Merged
merged 1 commit into from
Jul 1, 2017
Merged

Force the username to lowercase #90

merged 1 commit into from
Jul 1, 2017

Conversation

MattBlack85
Copy link
Contributor

No description provided.

kencochrane
kencochrane reviewed Jun 29, 2017
View reviewed changes
Copy link
Collaborator

@kencochrane kencochrane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only one minor comment. If the tests/checks pass, we can merge.

defender/utils.py
@@ -48,14 +48,21 @@ def get_ip(request):
return ip_address


def lower_username(username):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a docstring to this method, so the linters don't complain.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, adding it

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@kencochrane kencochrane mentioned this pull request Jun 29, 2017
Closed
@coveralls
Copy link

coveralls commented Jun 29, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 91.254% when pulling 4f53357 on MattBlack85:force_username_to_lower into fc9d51e on kencochrane:master.

@coveralls
Copy link

coveralls commented Jun 29, 2017 •
edited
Loading

Coverage Status

Coverage increased (+1.6%) to 92.74% when pulling 4f53357 on MattBlack85:force_username_to_lower into fc9d51e on kencochrane:master.

@coveralls
Copy link

coveralls commented Jun 29, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 91.254% when pulling 9ea985c on MattBlack85:force_username_to_lower into fc9d51e on kencochrane:master.

@kencochrane
Copy link
Collaborator

thank you, merging.

@kencochrane kencochrane merged commit 85817fd into jazzband:master Jul 1, 2017
@kencochrane kencochrane mentioned this pull request Aug 2, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kencochrane kencochrane kencochrane left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MattBlack85 @coveralls @kencochrane