Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix search bar cursor not blinking when focused #20

Merged
merged 1 commit into from
Nov 24, 2022
Merged

Conversation

kencx
Copy link
Owner

@kencx kencx commented Nov 23, 2022

Closes #14.

textinput's cursor was not blinking as:

  • Blinking was not properly initialized
  • The Update function call of handleSearch was placed inside the KeyMsg switch-case statement, which meant the cursor would only blink on every key press.
  • m.Reset() was being infinitely called when the search bar was empty (oops)

@kencx kencx merged commit 729a92b into master Nov 24, 2022
@kencx kencx deleted the blinkingCursor branch November 24, 2022 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add blinking cursor when search is focused
1 participant