Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GNNE-1891 ShapeBucket Optimize #1088

Merged
merged 63 commits into from
Sep 15, 2023
Merged

GNNE-1891 ShapeBucket Optimize #1088

merged 63 commits into from
Sep 15, 2023

Conversation

FusionBolt
Copy link
Contributor

  • Fix ShapeOf
  • AddSplitBatchToSpace
  • Add op for ShapeExpr
  • Replace i32 with i64 in ShapeExpr
  • Add some rule for ShapeExpr
  • Open all optimize feature
  • Add FullBucket for simple model

FusionBolt and others added 4 commits September 12, 2023 15:15
# Conflicts:
#	src/Native/src/kernels/stackvm/reference/pad.cpp
#	src/Nncase.Evaluator/ShapeExpr/GetPaddings.cs
#	src/Nncase.Passes/Rules/Neutral/FoldSqueeze.cs
#	src/Nncase.Passes/Rules/ShapeBucket/MergeCallToFusion.cs
#	src/Nncase.Passes/Rules/ShapeBucket/ShapeBucket.cs
#	src/Nncase.Passes/Rules/ShapeBucket/ShapeBucketHelper.cs
#	src/Nncase.Tests/Rules/ShapeBucket/ShapeBucketTest.cs
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch coverage: 64.83% and project coverage change: +0.71% 🎉

Comparison is base (d388629) 78.76% compared to head (8793b4e) 79.48%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1088      +/-   ##
==========================================
+ Coverage   78.76%   79.48%   +0.71%     
==========================================
  Files         659      676      +17     
  Lines       23319    23880     +561     
==========================================
+ Hits        18368    18981     +613     
+ Misses       4951     4899      -52     
Flag Coverage Δ
integration 40.89% <21.57%> (-0.38%) ⬇️
unit 72.44% <61.48%> (+0.85%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/Nncase.Evaluator/Math/Reduce.cs 42.66% <0.00%> (ø)
src/Nncase.Evaluator/NN/Conv2D.cs 67.27% <0.00%> (ø)
src/Nncase.Evaluator/ShapeExpr/BroadcastShape.cs 42.10% <0.00%> (+2.10%) ⬆️
src/Nncase.Evaluator/Tensors/Stack.cs 70.90% <0.00%> (ø)
...case.Passes/Rules/ShapeBucket/MergeBucketFusion.cs 72.40% <0.00%> (-2.24%) ⬇️
...odules.StackVM/CodeGen/StackVM/CodeGenVisitor.g.cs 63.87% <20.00%> (-4.64%) ⬇️
...case.Passes/Rules/ShapeBucket/ShapeBucketHelper.cs 49.22% <38.59%> (+0.96%) ⬆️
src/Nncase.Evaluator/ShapeExpr/ReshapeShape.cs 42.85% <42.85%> (ø)
src/Nncase.Evaluator/ShapeExpr/TransposeShape.cs 42.85% <42.85%> (ø)
src/Nncase.Evaluator/ShapeExpr/SqueezeShape.cs 44.44% <44.44%> (ø)
... and 44 more

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

github-actions bot commented Sep 12, 2023

Test Results

5 527 tests   5 527 ✔️  12m 1s ⏱️
       5 suites         0 💤
       5 files           0

Results for commit 8793b4e.

♻️ This comment has been updated with latest results.

@FusionBolt FusionBolt closed this Sep 13, 2023
@FusionBolt FusionBolt reopened this Sep 13, 2023
@FusionBolt FusionBolt closed this Sep 13, 2023
@FusionBolt FusionBolt reopened this Sep 13, 2023
@FusionBolt FusionBolt closed this Sep 14, 2023
@FusionBolt FusionBolt reopened this Sep 14, 2023
@FusionBolt FusionBolt merged commit 85011d8 into master Sep 15, 2023
23 of 24 checks passed
@FusionBolt FusionBolt deleted the shape-expr-opt branch September 15, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants