Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leak: Avoid disposing python stream in finalizer thread #1142

Merged
merged 2 commits into from
Dec 13, 2023

Conversation

sunnycase
Copy link
Member

No description provided.

Copy link

github-actions bot commented Dec 13, 2023

Test Results

5 859 tests  ±0   5 859 ✔️ ±0   7m 35s ⏱️ -18s
       6 suites ±0          0 💤 ±0 
       6 files   ±0          0 ±0 

Results for commit c71f9f1. ± Comparison against base commit c4f7b5f.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c4f7b5f) 73.23% compared to head (c71f9f1) 73.23%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1142      +/-   ##
==========================================
- Coverage   73.23%   73.23%   -0.01%     
==========================================
  Files         707      707              
  Lines       25801    25804       +3     
  Branches     4207     4207              
==========================================
+ Hits        18896    18898       +2     
- Misses       6264     6266       +2     
+ Partials      641      640       -1     
Flag Coverage Δ
integration 39.12% <100.00%> (+<0.01%) ⬆️
unit 65.08% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sunnycase sunnycase merged commit 980f977 into master Dec 13, 2023
43 of 44 checks passed
@sunnycase sunnycase deleted the fix/mem_leak branch December 13, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant