Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Quantize #1144

Merged
merged 22 commits into from
Dec 20, 2023
Merged

Refactor Quantize #1144

merged 22 commits into from
Dec 20, 2023

Conversation

FusionBolt
Copy link
Contributor

@FusionBolt FusionBolt commented Dec 18, 2023

  1. remove unused evaluate in GetHistogramsAsync
  2. clear unused memory in GetRangesAsync
  3. speed up SQuant

Copy link

github-actions bot commented Dec 19, 2023

Test Results

5 859 tests  ±0   5 859 ✔️ ±0   8m 8s ⏱️ +42s
       6 suites ±0          0 💤 ±0 
       6 files   ±0          0 ±0 

Results for commit bfbb9ed. ± Comparison against base commit 3a53346.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (3a53346) 73.18% compared to head (bfbb9ed) 73.16%.

Files Patch % Lines
...c/Nncase.Quantization/Quantization/QuantUtility.cs 96.51% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1144      +/-   ##
==========================================
- Coverage   73.18%   73.16%   -0.02%     
==========================================
  Files         706      706              
  Lines       25827    25818       -9     
  Branches     4212     4203       -9     
==========================================
- Hits        18901    18890      -11     
- Misses       6285     6286       +1     
- Partials      641      642       +1     
Flag Coverage Δ
integration 39.11% <0.99%> (+0.01%) ⬆️
unit 65.02% <97.02%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FusionBolt FusionBolt merged commit f7b4c7c into master Dec 20, 2023
43 of 44 checks passed
@FusionBolt FusionBolt deleted the refactor-quant branch December 20, 2023 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants