Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Reshape #1147

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Fix Reshape #1147

merged 1 commit into from
Dec 22, 2023

Conversation

FusionBolt
Copy link
Contributor

fix reshape for NotImplementedException

Copy link

github-actions bot commented Dec 21, 2023

Test Results

5 859 tests  ±0   5 859 ✔️ ±0   8m 16s ⏱️ -15s
       6 suites ±0          0 💤 ±0 
       6 files   ±0          0 ±0 

Results for commit 2f753a8. ± Comparison against base commit f7b4c7c.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (f7b4c7c) 73.16% compared to head (2f753a8) 73.16%.

Files Patch % Lines
src/Nncase.Evaluator/Tensors/Reshape.cs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1147      +/-   ##
==========================================
- Coverage   73.16%   73.16%   -0.01%     
==========================================
  Files         706      706              
  Lines       25818    25819       +1     
  Branches     4203     4203              
==========================================
- Hits        18891    18890       -1     
- Misses       6286     6287       +1     
- Partials      641      642       +1     
Flag Coverage Δ
integration 39.10% <0.00%> (-0.01%) ⬇️
unit 65.01% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhen8838
Copy link
Member

The same problem may not only appear in the reshape evaluator.

@FusionBolt
Copy link
Contributor Author

FusionBolt commented Dec 22, 2023

I will fix them in other pr.

@FusionBolt FusionBolt merged commit d355a38 into master Dec 22, 2023
42 of 44 checks passed
@FusionBolt FusionBolt deleted the fix/reshape branch December 22, 2023 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants