Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Not Equal #1156

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Fix Not Equal #1156

merged 1 commit into from
Jan 9, 2024

Conversation

FusionBolt
Copy link
Contributor

  1. replace != with !ReferenceEquals in CombineQuantizeConcat

Copy link

github-actions bot commented Jan 9, 2024

Test Results

5 859 tests  ±0   5 859 ✅ ±0   8m 27s ⏱️ ±0s
    6 suites ±0       0 💤 ±0 
    6 files   ±0       0 ❌ ±0 

Results for commit 252913f. ± Comparison against base commit ebac64a.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ebac64a) 72.88% compared to head (252913f) 72.88%.

Files Patch % Lines
src/Nncase.Passes/Rules/Neutral/CombineQuantize.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1156   +/-   ##
=======================================
  Coverage   72.88%   72.88%           
=======================================
  Files         706      706           
  Lines       25923    25923           
  Branches     4227     4227           
=======================================
  Hits        18895    18895           
  Misses       6384     6384           
  Partials      644      644           
Flag Coverage Δ
integration 38.97% <0.00%> (ø)
unit 64.77% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FusionBolt FusionBolt merged commit aa69f57 into master Jan 9, 2024
43 of 44 checks passed
@FusionBolt FusionBolt deleted the fix/ref_eql branch January 9, 2024 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants