Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix fold binary #1182

Merged
merged 1 commit into from
Apr 12, 2024
Merged

fix fold binary #1182

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/Nncase.Passes/Rules/Neutral/FoldBinary.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,14 @@ public sealed partial class FoldNopBinary : IRewriteRule
/// <inheritdoc/>
public IPattern Pattern { get; } = IsBinary(
"binary",
"call",
x => x.BinaryOp is BinaryOp.Add or BinaryOp.Sub or BinaryOp.Mul or BinaryOp.Div or BinaryOp.Mod or BinaryOp.Pow,
IsWildcard("lhs"),
IsTensorConst("rhs"));

private Expr? GetReplace(Binary binary, Expr lhs, TensorConst rhs)
private Expr? GetReplace(Binary binary, Call call, Expr lhs, TensorConst rhs)
{
if (lhs.CheckedType is Nncase.IR.AnyType || lhs.CheckedShape == rhs.CheckedShape)
if ((lhs.CheckedType is Nncase.IR.AnyType && rhs.CheckedShape.IsScalar) || (lhs.CheckedShape == call.CheckedShape))
{
return binary.BinaryOp switch
{
Expand Down
Loading