New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use nikic/php-parser as a Composer dependency if you use Composer #166

Merged

kenjis merged 2 commits into master from remove-replace-php-parser

Feb 4, 2017

Owner

kenjis commented Feb 4, 2017 •

edited

Loading

PHP-Parser is only used if you use Monkey Patching in ci-phpunit-test.

Before:

ci-phpnit-test has PHP-Parser source code inside, and always uses it.
In Composer context, ci-phpunit-test replaces PHP-Parser.

After:

If you use Composer (you install ci-phpunit-test via Composer), ci-phpunit-test uses PHP-Parser Composer package.
In Composer context, ci-phpunit-test depends on PHP-Parser package.
If you don't use Composer, ci-phpunit-test uses PHP-Parser source code inside.

kenjis added 2 commits

February 4, 2017 09:40


          Now nikic/php-parser is a Composer dependency

c179319


          If you use Composer, use PHP-Parser as Composer package

230ee3a

coveralls commented Feb 4, 2017

Changes Unknown when pulling 230ee3a on remove-replace-php-parser into ** on master**.

kenjis merged commit aac8a82 into master

kenjis deleted the remove-replace-php-parser branch

February 4, 2017 01:07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment