Fix patchConstant when the user does not specify $class_method #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a user calls patchConstant without the argument $class_method the docs explain the constant will changed everywhere.
However, the code will store in $patches_to_apply[$constant] the result of strtolower($class_name) ==> strtolower(null) ==> "". When we check if we have to return the patched value we will always return false, as we check with `isset` the variable $patches_to_apply[$constant] (this will always be true) and when we proceed to check the value of $patches_to_apply[$constant] (the empty string) with the current class it always fails the test.
The end result is that a call to patchConstant('FOO', 1); never changes the constant FOO.
|
@e98cuenc Thank you for your PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user calls patchConstant without the argument $class_method the docs explain the constant will changed everywhere.
However, the code will store in $patches_to_apply[$constant] the result of strtolower($class_name) ==> strtolower(null) ==> "". When we check if we have to return the patched value we will always return false, as we check with
issetthe variable $patches_to_apply[$constant] (this will always be true) and when we proceed to check the value of $patches_to_apply[$constant] (the empty string) with the current class it always fails the test.The end result is that a call to patchConstant('FOO', 1); never changes the constant FOO.