support for rds #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
もし動くならこれで一旦mergeしてしまって問題ないかと思います。 変数に何が入ってるのか、デバッグ目的でJSONが格納されている ちょっとコードが大きくなってきたので簡潔にできるところは簡潔にできるよう あと 時間があれば
をします。@toritori0318 さんもお時間あればご協力をお願いします！ |
|
@kenjiskywalker ご確認ありがとうございます！ |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RDS対応を行いました。以下の点を変えています。
・CLIにサブコマンド追加(rikanjo ec2 / rikanjo rds)
・CLIのRDSコマンドのみ--multiazオプション追加
・モードによりec2/rdsクラスを切り分け
・Net::HTTP.getの使い方を変更（既存の手法だと何故かrdsのjsが取れなかったため）
ec2とrdsで「インタフェースは同じ」かつ「中身が異なる」箇所が多々あった関係で
コードを結構変えてしまいました…
問題ありましたらご指摘お願い致します。