Avoid new connections to the primary node. #35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasdower
changed the title
nicholasdower
force-pushed
the
primary
branch
2 times, most recently
from
51338c7
to
ff353f2
Compare
`Standby::Base.inside_transaction?` uses `ActiveRecord::Base.connection` on the primary to check whether access to the standby is occurring from within a transaction. `ActiveRecord::Base.connection` looks for a cached connection belonging to the current thread and, if it doesn't find one, attempts to checkout a connection from the connection pool. If the connection pool is exhausted, it blocks for up to `ConnectionPool#checkout_timeout` (default 5 seconds). This change skips the transaction check if a connection has not been cached for the current thread. The assumption is there cannot be a current transaction without a current connection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#36
Standby::Base.inside_transaction?usesActiveRecord::Base.connectionon the primary to check whether access to the standby is occurring from within a transaction.ActiveRecord::Base.connectionlooks for a cached connection belonging to the current thread and, if it doesn't find one, attempts to checkout a connection from the connection pool. If the connection pool is exhausted, it blocks for up toConnectionPool#checkout_timeout(default 5 seconds).This change skips the transaction check if a connection has not been cached for the current thread. The assumption is there cannot be a current transaction without a current connection.
Also rename
slavery_spec.rbto match renames done in d0e8c74.