Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed support 'freezing daemon-kit into vendor/' #74

Merged
merged 7 commits into from
Sep 17, 2013

Conversation

kennethkalmer
Copy link
Owner

This is such a relic of the pre-bundler days. We can now simply have folks update their Gemfile to point to our master branch directly, no need to special 'vendor/daemon-kit' magic.

[ ] - Cleanup boot.rb
[ ] - Make sure it can be upgraded cleanly with rake daemon_kit:upgrade
[x] - Document in upgrading.txt
[ ] - Document in post-install, blog post etc

This might just break 0.2.x upgrades

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.53%) when pulling 9f89374 on living-on-the-edge into ef4573a on master.

@marcbowes
Copy link
Collaborator

:shipit:

@kennethkalmer
Copy link
Owner Author

@marcbowes 👍

Just need to tweak the daemon_kit:upgrade task to use the app generator, but invoke selectively.

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.35%) when pulling 8ec558e on living-on-the-edge into ef4573a on master.

@kennethkalmer
Copy link
Owner Author

@marcbowes eyes please, I'm not too happy with a stub project added in 286a8e5, but is was needed to the scenario added in 17b10d8

I think this branch is good to be merged!

@kennethkalmer
Copy link
Owner Author

We can always refine the tests after 0.3 drops, just want the upgrade process to be smooth.

@marcbowes
Copy link
Collaborator

lgtm

@kennethkalmer
Copy link
Owner Author

👍

Let me just fix the failures caused by rspec trying to load the fixtures directory and subsequently failing to boot the daemon :/

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.79%) when pulling 2d8eaed on living-on-the-edge into ef4573a on master.

kennethkalmer added a commit that referenced this pull request Sep 17, 2013
Removed support 'freezing daemon-kit into vendor/'
@kennethkalmer kennethkalmer merged commit 2be5551 into master Sep 17, 2013
@kennethkalmer kennethkalmer deleted the living-on-the-edge branch September 17, 2013 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants