Fix relative log file creation #83
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 5, 2014 11:53
When running locally on a Mac, it seems that passing a relative path to the log argument doesn't create the expected log file. This will prepend the DAEMON_ROOT to the passed in path if needed so we get a good path.
| @@ -194,6 +194,14 @@ def create_logger | |||
| end | |||
| end | |||
|
|
|||
| def set_logger_file(log_path) | |||
| if log_path | |||
| log_path.start_with?('/') ? log_path : [DAEMON_ROOT, log_path].join('/') | |||
There was a problem hiding this comment.
Yeah, it may be an issue, but since I don't write or deploy to a Windows box, I have no way of testing it. My workaround for the current version is just to pass the full absolute path. Maybe a better solution is to just change the filename, which is all I really need to do anyway.
|
Windows issues aside, how about making it a little more flexible and provide users with a mechanism to outright replace the logger with their own configured instance of a logger that looks like a logger? |
|
Should we just merge this as is? I'm inclined. |
|
Let me take a spike at the alternative, if it goes well we can compare notes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing a relative path for the log file doesn't work on a Mac, and possibly elsewhere. If the passed in log argument is not an absolute path, it will now prepend the DAEMON_ROOT.
Also, fix rspec deprecation warnings.