Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soft-deleted fee name or handle can conflict with new #16

Open
kennethormandy opened this issue Mar 16, 2021 · 0 comments
Open

Soft-deleted fee name or handle can conflict with new #16

kennethormandy opened this issue Mar 16, 2021 · 0 comments

Comments

@kennethormandy
Copy link
Owner

Fees need to have a unique handle or name. Fees are soft-deleted. It’s possible that you might add a fee, delete it, and then add another fee back with the same handle or name as a soft-deleted fee.

The UniqueValidator::class rule doesn’t seem to account for this automatically, so I am showing an error when this happens, to avoid a much more confusing error. Now:

Screen Shot 2021-03-15 at 7 37 05 PM

Instead, should probably hard-delete the old fee, and continue creating the new fee? Getting the trashed record and continuing to modify it from there doesn’t seem to work. It restores the trashed record as it was, and you get a notice that (now) the fee handle is a duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant