Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid infinite recursion on unsupported Lisps #3

Merged
merged 1 commit into from Mar 1, 2015

Conversation

quicklisp
Copy link
Contributor

When a Lisp isn't in the supported list, the system file still tries to add a method to ASDF:PERFORM. The (find-system :utils-kt) in the lambda list then recursively calls find-system, fails to find the undefined utils-kt, and loads utils-kt.asd again, invoking defmethod again, ad infinitum (or until it blows the stack).

This change signals an error on unsupported Lisps instead.

When a Lisp isn't in the supported list, the system file still tries to add a method to ASDF:PERFORM. The (find-system :utils-kt) in the lambda list then recursively calls find-system, fails to find the undefined utils-kt, and loads utils-kt.asd again, invoking defmethod again, ad infinitum (or until it blows the stack).

This change signals an error on unsupported Lisps instead.
kennytilton added a commit that referenced this pull request Mar 1, 2015
Avoid infinite recursion on unsupported Lisps
@kennytilton kennytilton merged commit 6aa870e into kennytilton:master Mar 1, 2015
@kennytilton
Copy link
Owner

Thx. Just merged. -kt

On Sat, Feb 28, 2015 at 5:59 PM, Zach Beane notifications@github.com
wrote:

When a Lisp isn't in the supported list, the system file still tries to
add a method to ASDF:PERFORM. The (find-system :utils-kt) in the lambda
list then recursively calls find-system, fails to find the undefined
utils-kt, and loads utils-kt.asd again, invoking defmethod again, ad
infinitum (or until it blows the stack).

This change signals an error on unsupported Lisps instead.

You can view, comment on, or merge this pull request online at:

#3
Commit Summary

  • Avoid infinite recursion on unsupported Lisps

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#3.

Kenneth Tilton
54 Isle of Venice Dr
Fort Lauderdale, FL 33301

ken@tiltontec.com
http://tiltontec.com
@tiltonsalgebra

646-269-1077

"In a class by itself." -Macworld

@kennytilton
Copy link
Owner

ps. Untested by moiself.

On Sun, Mar 1, 2015 at 3:26 AM, Kenneth Tilton ken@tiltontec.com wrote:

Thx. Just merged. -kt

On Sat, Feb 28, 2015 at 5:59 PM, Zach Beane notifications@github.com
wrote:

When a Lisp isn't in the supported list, the system file still tries to
add a method to ASDF:PERFORM. The (find-system :utils-kt) in the lambda
list then recursively calls find-system, fails to find the undefined
utils-kt, and loads utils-kt.asd again, invoking defmethod again, ad
infinitum (or until it blows the stack).

This change signals an error on unsupported Lisps instead.

You can view, comment on, or merge this pull request online at:

#3
Commit Summary

  • Avoid infinite recursion on unsupported Lisps

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#3.

Kenneth Tilton
54 Isle of Venice Dr
Fort Lauderdale, FL 33301

ken@tiltontec.com
http://tiltontec.com
@tiltonsalgebra

646-269-1077

"In a class by itself." -Macworld

Kenneth Tilton
54 Isle of Venice Dr
Fort Lauderdale, FL 33301

ken@tiltontec.com
http://tiltontec.com
@tiltonsalgebra

646-269-1077

"In a class by itself." -Macworld

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants