Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix logging of error objects. #44

Merged
merged 1 commit into from
Nov 13, 2015

Conversation

dmiddlecamp
Copy link
Contributor

fixes an error where

var foo = new Error("something");

// Foo is not relayed to Papertrail.
logger.log("test, foo);

@matteocontrini
Copy link

Up

@brocksamson
Copy link

+1, I need this fix for several use cases in my project.

@matteocontrini
Copy link

@kenperkins can you hit that merge button, for God's sake? Thanks.

@troy
Copy link
Contributor

troy commented Nov 7, 2015

@matteocontrini I just inquired with @kenperkins outside of GitHub. if Ken isn't able to merge this in the next week or two, Papertrail is going to create a new repo and recommend abandoning this repo. I'd really prefer to continue to use this repo, history, etc, but I totally agree with you that something needs to move here.

@matteocontrini
Copy link

@troy thanks for the update and for the interest on this from Papertrail 👍

@kingjerod
Copy link

@troy Thanks for the update. There are some outstanding issues here that really need fixing (like this library can't handle exceptions properly). Will be good to get things updated again.

@kenperkins
Copy link
Owner

@troy and I spoke today, and I've made @troy a maintainer. Sorry for my inaccessibility I've had a significant reduction in my coding bandwidth.

@matteocontrini
Copy link

@kenperkins thank you for the collaboration 😄 👍

@kingjerod
Copy link

Awesome! 👍

kenperkins added a commit that referenced this pull request Nov 13, 2015
fix logging of error objects.
@kenperkins kenperkins merged commit 1f39814 into kenperkins:master Nov 13, 2015
@dmiddlecamp
Copy link
Contributor Author

👍 Thanks!

@ghost
Copy link

ghost commented Nov 17, 2015

Can we get this released to npm please. :-)

@kenperkins
Copy link
Owner

Certainly, I want to get #46 in as well. I'll try to do this today.

@jacobdr
Copy link

jacobdr commented Nov 23, 2015

+1

@matteocontrini
Copy link

@kenperkins can we have a release, with or without #46? There are already some important improvements. Thanks

@kenperkins
Copy link
Owner

This has been published as 1.0.2. I'm working on #46 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants