Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added page method to retrieve full url [like: /wiki/#{HTML_Escaped_Page_... #20

Closed
wants to merge 1 commit into from

Conversation

mbologna
Copy link

@mbologna mbologna commented May 6, 2014

Hi!
retrieve a Page URL using Page#fullurl seems to not work anymore (always retrieves nil).
I changed it to correctly retrieve the Page URL from Wikipedia, using:

  • configuration to generate the correct URL
  • URI encode the page title
  • appending curid

#{protocol}://#{domain}/wiki/#{HTML_Escaped_Page_Title}?curid=#{curid}

Note: Page title could be anything as soon as we provide a curid.

@kenpratt kenpratt force-pushed the master branch 3 times, most recently from 28e1947 to 00c0df0 Compare June 25, 2015 20:43
@pietromenna
Copy link
Collaborator

Hi @mbologna,

Sorry for the late response. I did not experience the problem you described (getting nil as response when requesting a page#fullurl).

Do you believe that using curid field is a better practice than just the Page#fullurl? If yes, why?

Do you believe we could add some tests for the new format?

@mbologna mbologna closed this Nov 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants