Image thumburls #71
Merged
Image thumburls #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ok, not so good. i should have run the specs myself.. will do asap. |
|
Hi @panaak , Thank you very much for your contribution! I am glad you took the opportunity to write a feature requested by others. The changes look ok, but I am missing unit tests for the new feature. Let me know if you need some help with those. |
|
OK, tests added and passing. |
|
Thanks a lot @panaak ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as a response to #70 i tried to implement this. i'm not sure this is the right approach, but at least i tried..)
the default width is hard coded to Client, but could be added to the configuration directives i guess.