Slash fix #78
Merged
Slash fix #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @pcantrell , Thank you for this Pull Request! This seems to be working just fine! I will release a new version tomorrow. |
|
Excellent! Thanks, and thank you for putting together this very helpful gem. |
|
Thank you for your comments! I wish you success with your project! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the handling of article titles containing slashes, which Wikipedia canonicalizes as if the slash were part of a path, e.g.
https://en.wikipedia.org/wiki/PL/SQL.This changes how
Urlextracts titles; it now specifically looks for the/wiki/prefix. The specs still pass, but let me know if that change is going to break something.(I discovered #76 pointing at the C++ article; this one comes from PL/SQL. Guess what topic my little Wikipedia project involves….)