Load 500 first langlinks for pages too #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checks fail because of #80 |
|
Hi @imustafin , Thank you very much for your PR. The tests are not passing. I checked that you sent another PR (#80 ) which seems to fix the test. Would you mind to send the commit in the second PR to this PR? You can do this by adding the other commit to the branch you used in this pull request. Let me know if you need further help. |
|
Like this? |
|
Yes! Also, you could add an example to this file (https://github.com/kenpratt/wikipedia-client/blob/master/README.textile) and sign your work by adding your name to contributors 👍 What do you think about it? |
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Langlinks are links to translations of a page (MediaWiki API).
This patch adds
Page#langlinksmethod which returns a hash{ lang_code => title }.I changed
Client#request_pageto include langlinks in the result. This makes test fixtures (files in/spec/fixtures/) kinda invalid because they do not contain langlinks. For the test ofPage#langlinksI made a new fixture of a new page. Should I update the current fixtures and update the tests for the new version or we leave them as they are?