Move dev dependencies to Gemfile and lock rubocop version
#90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenpratt
approved these changes
Apr 28, 2021
| gem 'pry' | ||
| gem 'rake' | ||
| gem 'rdoc' | ||
| gem 'rspec' |
There was a problem hiding this comment.
What do you think about putting major versions here (eg gem 'rspec', '~> 3.0')? Not necessary?
There was a problem hiding this comment.
I my opinion, absolutely not necessary. In all my gems I am using the same approach. We want devs to always use the latest. This way, you make it a habbit to occasionally do bundle update and bundle outdated, to ensure everything is new.
The only reason to occasionally lock versions, is when something is broken and we do not have time to fix it.
I am no expert on these matters - but this is how I roll.
There was a problem hiding this comment.
Got it, that sounds good to me.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #89, this PR offers a little housekeeping:
gemspectoGemfileGemfile.lockto.gitignorerubycopversion to the version that worked the last time someone used it, so that it is not blocking CI tests.