Fix indent overflow #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -36,7 +56,9 @@ | |||
| indent: { | |||
| iconClass: "icon-indent-right", | |||
| action: function(event) { | |||
| document.execCommand("indent"); | |||
| if (rightIndentPixels() + blockQuoteMargin < parseInt($(".editor").css("width"))) { | |||
There was a problem hiding this comment.
Callback action will be passed two parameters, event and popline itsself. Please use popline.target instead of hard code $(".editor").
Because the target selector is defined by user.
Thanks
|
My bad! Fixed this now. |
| // Left margin of a blockquote element. | ||
| var el = $("<blockquote></blockquote>"); | ||
| var blockQuoteMargin = parseInt(el.hide().appendTo("body").css("marginLeft")); | ||
| el.remove(); |
There was a problem hiding this comment.
@amitburst It's better to put the margin calculate into $(document).ready. Wherever the scripts to be placed, it will always works.
|
Can you rebase it after fix the issue? Thx. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4
The main issue here is that
document.execCommand("indent")nests the selected line in blockquotes. Eventually, the summed margins of these nested blockquotes will cause the paragraph to overflow out of the editor div. I've fixed this by comparing the sum of blockquote margins to the width of the editor, so this is flexible if you later decide to change the default indent size.I also moved the scripts to the bottom of
index.htmlto ensure that DOM manipulation (needed for computing blockquote margin) functions correctly. It's good style anyway to put JavaScript at the end of the body, since it blocks rendering. :)