Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified PR about pre/post-padding, supports masking, index input (no rows), pickled char map #24

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

pinesnow72
Copy link

I modified followings:

  • add an option for selecting pre or post-padding
  • add mask support to ContextualizedEmbedding
  • modified forward/backward index input by removing rows (sentence indices) and using tf.gather_nd with batch_dims=1
  • add to script to extract charmap (char-to-int dictionary) from Flair embeddings and store it as a pickle
  • use pickled charmap instead of char_to_int.py

@ydovzhenko
Copy link
Contributor

Ok thanks! Give me a day to review carefully.

So the word is, Travis CI is not reliable for testing anymore. I'm working on a PR to switch from Travis CI to github actions, will also take a day or two. Then the checks on your PR will run. Stay tuned:-)

@ydovzhenko ydovzhenko self-requested a review July 26, 2021 15:53
@ydovzhenko
Copy link
Contributor

Hey, my bad for not getting back to you - I was behind on a deadline. I'll review within a week from now. I have not forgotten:-) Thank you for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants