Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python 3.7 to the Travis testing matrix #148

Merged
merged 5 commits into from Dec 28, 2018
Merged

Add python 3.7 to the Travis testing matrix #148

merged 5 commits into from Dec 28, 2018

Conversation

obi1kenobi
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.185% when pulling 79bc4ee on py3.7 into d12336d on master.

@coveralls
Copy link

coveralls commented Dec 25, 2018

Coverage Status

Coverage remained the same at 95.185% when pulling 30c1eaa on py3.7 into 2d903d2 on master.

jmeulemans
jmeulemans previously approved these changes Dec 26, 2018
Copy link
Collaborator

@jmeulemans jmeulemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a minor question regarding sudo, but either way this looks good to go.

.travis.yml Outdated
@@ -28,6 +28,11 @@ matrix:
python: "3.6"
script:
- py.test --cov=graphql_compiler graphql_compiler/tests
- name: "Python 3.7 unit tests"
python: '3.7'
sudo: true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does 3.7 require sudo when the others don't? I see that used to be an issue, but this repo at least seems to think the issue has since been resolved: https://github.com/deadsnakes/travis-ci-python3.7-example

@obi1kenobi obi1kenobi merged commit 00c0027 into master Dec 28, 2018
@obi1kenobi obi1kenobi deleted the py3.7 branch December 28, 2018 17:15
@obi1kenobi obi1kenobi mentioned this pull request Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants