Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename __count meta field to _x_count and release v1.10.0. #176

Merged
merged 3 commits into from Jan 31, 2019

Conversation

obi1kenobi
Copy link
Contributor

No description provided.

lodrion
lodrion previously approved these changes Jan 31, 2019
@nmutalik
Copy link

nmutalik commented Jan 31, 2019

maybe worth linking to this? idk https://facebook.github.io/graphql/draft/#sec-Reserved-Names

@obi1kenobi
Copy link
Contributor Author

maybe worth linking to this? https://facebook.github.io/graphql/draft/#sec-Reserved-Names

Added:

We do not use the GraphQL standard double-underscore (`__`) prefix for meta fields,
since all names with that prefix are
[explicitly reserved and prohibited from being used](https://facebook.github.io/graphql/draft/#sec-Reserved-Names)
in directives, fields, or any other artifacts.

@obi1kenobi obi1kenobi merged commit 0d810a0 into master Jan 31, 2019
@obi1kenobi obi1kenobi deleted the rename_count branch January 31, 2019 20:47
@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.223% when pulling f224baa on rename_count into a114ae3 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants