Refactor schema graph #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refactored SchemaElement to use a class hierarchy * Correctly set metaclass in a python2/python3 compatible way * Nit * Removed abstractmethod decorator from init method * Changed Vertex to VertexType and Edge to EdgeType * Added unicode compatibility decorator * Fixed class name typos * Use issubclass instead of class equality * Added generic string representation * Changed kind to kind_cls * Fixed args bug * Removed __str__ overrides * Added freeze method for all SchemaElements * Made SchemaElement and GraphElement classes truly abstract * Fixed linter errors * Added comment explaining why we make the init method abstract
* Added _try_get_exact_link_from_superclasses * Created _is_abstract method * Seperated get class fields into its own function * Created _get_element_properties method * Removed allowed_duplicate_properties variable * Nits * Nits
* Decomposed _get_element_properties into two functions * Use funcy split instead of partition function * Specified funcy version
* Removed _get_element_properties method * Createdseperate setup function for each element kind
…to be class attributes of EdgeType
Remove link properties
Sorted imports Fixed linter errors
…ered-class-collection-properties Add warning for filtered class collection properties
…h-class-collections Refactor schema graph class collections
This reverts commit 2cb4f15.
…h-constructor Refactor schema graph constructor
Shorten module name
* Allow connections for NonGraphElements * Renamed misleading function
…es-of-class Fix _get_elements_of_class
Added missing in_connections and out_connections to the printed fields
bojanserafimov
approved these changes
May 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major changes: