Update sqlalchemy schema generation branch #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added indexes to the SchemaGraph * Add additional index methods and remove type field * Nits * Nits * More nits * More nits * Changed all_indexes to indexes * Revert "Changed all_indexes to indexes" This reverts commit 44ffd00. * Nit * Addressed code review comments * Prohibit null value ignoring for edge indexes * Fix typo * Stop overriding ignore_nulls for edge indexes to true * Fix typo
* Add immediate superclasses dict * Make toposorting not use OrientDB constructs. * Refactored InheritanceStructure constructor * Move inheritance structure class and related methods * Fixed docstring * Added documentation for InheritanceStructure class * Nits * Return validation to its original place * Fix terminology * More nits * More nits * More nits * Re-add list coercion
* Add indexes to test SchemaGraph * Changed sets arguments to lists and remove is None check
* Add output info to query metadata * Update explain info tests * Add output tests to explain_info * Remove context output * Add docstring metadata outputs property * Use query_metadta_table variable and name * Replace more names with query_metadata_table * Remove fold from OutputInfo
* Fix index documentation * Nit
#324) * Refactor and clean up IR lowering code. Add common IR lowering operations module. * Delint. * Improve expression comment around null values. * Add defensive strip_non_null_from_type() call.
…y-schema-generation-granch
bojanserafimov
approved these changes
May 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.