This repository has been archived by the owner on Dec 14, 2019. It is now read-only.
Refactor enhancers #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billyjanitsch
force-pushed
the
billy/enhancers
branch
2 times, most recently
from
c7c16f8
to
6fe40d1
Compare
|
This looks good in the sandbox, but I'd be more comfortable merging it with more examples to test against (#92) -- especially a Brush example. |
billyjanitsch
force-pushed
the
billy/enhancers
branch
from
6fe40d1
to
362c3e5
Compare
billyjanitsch
force-pushed
the
billy/enhancers
branch
from
362c3e5
to
7e485eb
Compare
|
The sandbox -- including the brush example -- seem to be working fine with this change, so I think it's ready to merge pending review. |
nabeel-
approved these changes
Jun 5, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
stateHOCtowithControlledStateandchartWidthHOCtowithComputedWidthand move them both to an enhancers/ folder. Also significantly simplify the former.I need to test this internally to make sure I haven't broken anything, so please don't merge yet.
This should also land after #87 since it would otherwise break Highlight.