This repository has been archived by the owner on Aug 13, 2020. It is now read-only.
feat(dependencies): add support for headers and statusText in http mock #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bahmutov
added a commit
that referenced
this pull request
Dec 3, 2015
feat(dependencies): add support for headers and statusText in http mock
|
Thank you very much |
|
Can I also ask you to document this feature in the docs/ please? |
|
Yes, should I amend it in last commit ? |
|
oh, you can use even a separate PR, no problem |
|
I'd rather push it in same commit if you don't mind remerging for logs readibility |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ng-describe lacked the functionality of mocking headers in http request.
As I needed it, this resulted in this PR.
Let me know if it's fine for you and thanks for your work