Make watchdog working with jedis pool #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanimrod
reviewed
Sep 5, 2017
| jedis.evalsha(watchdogScriptHash.get(), WATCHDOG_SCRIPT_KEYS_NUMBER, serverName, REQUEUE_JOBS, isDebug); | ||
| return null; | ||
| }); | ||
| break; |
There was a problem hiding this comment.
This is a bad practice.. using break to get out of a loop.
This makes code less readable as you have multiple exit point from the loop to look at...
| int requeueJobsRetryNum = 0; | ||
|
|
||
|
|
||
| while (requeueJobsRetryNum <= REQUEUE_JOBS_RETRY_NUM) { |
There was a problem hiding this comment.
Why do we need the retry here?
Let's define the pool that will check the connection before borrow. It's less critical here as this code is running only when a server is going down.
nanimrod
approved these changes
Sep 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.