Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please consider make this package Dart 3 compatible #37

Closed
MagnusJohansson opened this issue May 31, 2023 · 3 comments
Closed

Please consider make this package Dart 3 compatible #37

MagnusJohansson opened this issue May 31, 2023 · 3 comments

Comments

@MagnusJohansson
Copy link

MagnusJohansson commented May 31, 2023 •
edited
Loading

Currently, it depends on http 0.13.3.
It should be upgraded to use the latest Dart 3 compatible http package 1.0.0

Because azure_application_insights 3.1.0 depends on http ^0.13.0 and no versions of azure_application_insights match >3.1.0 <4.0.0, azure_application_insights ^3.1.0 requires http ^0.13.0.
So, because my_app depends on both azure_application_insights ^3.1.0 and http ^1.0.0, version solving failed.

Thanks.
@MagnusJohansson
Copy link
Author

MagnusJohansson commented May 31, 2023 •
edited
Loading

Made a PR: #38 , @kentcb please check

@MagnusJohansson
Copy link
Author

Regarding the unit testing and mocking, can you consider changing the test to not mock the ByteStream , but rather the StreamedResponse ?
As mentioned in this comment: dart-lang/http#956 (comment)

@kentcb
Copy link
Owner

kentcb commented Jul 22, 2023

Resolved by #40 and published

@kentcb kentcb closed this as completed Jul 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MagnusJohansson @kentcb