Updated dependencies to Dart3/Flutter 3.10 compatible ones #38
Conversation
pubspec.yaml
Outdated
| @@ -1,21 +1,21 @@ | |||
| name: azure_application_insights | |||
| description: A Dart client to integrate with Azure's Application Insights service | |||
| version: 3.1.0 | |||
| version: 3.1.1 | |||
There was a problem hiding this comment.
Since the SDK major version has incremented, I think we should bump this package to version 4.0.0?
There was a problem hiding this comment.
Yes, I would say it's a good idea. I've updated the PR.
| logging: ^1.0.2 | ||
| meta: ^1.3.0 | ||
| stack_trace: ^1.10.0 | ||
| http: '>=0.13.6 <2.0.0' |
There was a problem hiding this comment.
Why the change in syntax here? Can we just do ^1.0.0?
There was a problem hiding this comment.
For sure you can go with a single entry ^1.0.0. But then everybody who are using this package are forced to also use the http package version 1.0.0 - <2.0.0.
If you use '>=0.13.6 <2.0.0' , you will be compatible with http version 0.13.6 up to (but not including) 2.0.0.
In other words, both developers who must be on legacy 0.x.x can do so , as well as devs who are using the later 1.x.x
Specifying a single version (with caret): ^0.13.6 is the same as '>=0.13.6 <1.0.0' (i.e. excluding v1.0.0).
Reference:
Caret syntax
Versioning
There was a problem hiding this comment.
Ah, I get it now. I thought that using SDK 3 would require the use of http 1.0.0 onwards, but I see that it's still possible to use older versions with newer SDKs.
|
Looks like there are some problems with the build, presumably as a result of SDK 3. I don't have time right now to dig in, but am happy to do so when I free up. If you're keen, feel free to take a look @MagnusJohansson. |
|
Yes, I see... it seems that the Dart team in their infinite wisdom decided to mark the ByteStream class as final (instead of interface) which prevents Mockito to mock it... |
|
@kentcb Can the tests be modified to not mock the ByteStream, as per this comment? |
|
Resolved by #40 and published |
Update the SDK to v3, additional updates for various packages