fix(plugin): Safe access to leadingComments #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent error when `path.node.body` is not defined Closes #20
Codecov Report
@@ Coverage Diff @@
## master #26 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 4 4
Lines 97 98 +1
Branches 19 20 +1
=====================================
+ Hits 97 98 +1
Continue to review full report at Codecov.
|
kentcdodds
approved these changes
Aug 13, 2017
|
Would you like to add yourself to the contributors table? |
|
No problem, and sure I'll make a PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Prevents error on preval when dealing with empty files
Why:
path.node.bodycan be undefined, these changes make sure we safely accessleadingCommentsproperty.How:
Your suggested code changes and test cases
Prettier added a couple additional changes as part of the precommit hook, I wasn't sure if you wanted to keep these in or not
Closes #20