feat(getByText): add ignore option which defaults to 'script'
#109
Conversation
kentcdodds
requested review from
wyze,
wgcrouch,
sompylasar,
alexkrolick,
maddijoyce,
jomaxx,
lgandecki,
rbrtsmith and
npeterkamps
Codecov Report
@@ Coverage Diff @@
## master #109 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 9 9
Lines 184 185 +1
Branches 50 51 +1
=====================================
+ Hits 184 185 +1
Continue to review full report at Codecov.
|
|
More explanation here: https://www.youtube.com/watch?v=LYB0SEYaBlE |
| exact = true, | ||
| collapseWhitespace = true, | ||
| trim = true, | ||
| ignore = 'script', |
There was a problem hiding this comment.
I think script and style would be a better default.
There was a problem hiding this comment.
Good idea. I'll add that!
There was a problem hiding this comment.
But I'm just a couple minutes late...
There was a problem hiding this comment.
No worries. I just pushed an update directly to master. I figured the overhead would be unnecessary.
|
🎉 This PR is included in version 3.7.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
What: add
ignoreoption to*ByTextwhich defaults to'script'Why:
In our app at PayPal we're testing with Cypress and our localization content is set in a script tag on the page when it's rendered by the server. When using
getByTextwithcypress-testing-library, we were getting that script tag before the app had a chance to render.I'm pretty confident that 99.999% of the time people wont want to get a script tag with
getByText, so the default makes sense to me.How:
Added another layer of filtering to
queryAllByTextto filter nodes which return true for.matches(ignore). Feel pretty flexible. Happy that DOM API exists!Checklist: