fix: Reference Node and MutationObserver off of the window object #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…her than globally You have to handle shims yourself if not using jest without this
|
Would you like to add yourself to the contributors table? |
|
🎉 This PR is included in version 3.0.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
Sure! I felt awkward doing that with such a small change. Should I make another commit on this branch? or create a new one? |
|
I recommend creating a new branch for every PR. You may also appreciate this: http://makeapullrequest.com/ :) |
|
I definitely appreciate that :) |
alexkrolick
added a commit
to alexkrolick/dom-testing-library
that referenced
this pull request
Sep 13, 2018
* Update README with new match examples * Update types (probably invalid typescript syntax) * Remove example that messes up TOC * Fix union type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Reference Node and MutationObserver off of the window object rather than globally
You have to handle shims yourself if not using jest without this
What:
Changes references to
NodeandMutationObserverto usewindowrather than globally.Why:
The polyfills/shims do not work in a non-jest environment
How:
Node->window.NodeMutationObserver->window.MutationObserverChecklist: