Override rules with @typescript-eslint rules for ts(x) files

kentcdodds · Jul 26, 2020 · 4736361 · 4736361
1 parent a7a2da2
commit 4736361
Show file tree

Hide file tree

Showing 6 changed files with 81 additions and 2 deletions.
diff --git a/best-practices.js b/best-practices.js
@@ -110,4 +110,33 @@ module.exports = {
     'no-restricted-modules': 'off',
     'no-sync': 'off',
   },
+  overrides: [
+    {
+      files: ['**/*.ts?(x)'],
+      rules: {
+        'default-param-last': 'off',
+        '@typescript-eslint/default-param-last': 'off',
+        'no-empty-function': 'off',
+        '@typescript-eslint/no-empty-function': 'off',
+        'no-magic-numbers': 'off',
+        '@typescript-eslint/no-magic-numbers': 'off',
+        'no-return-await': 'off',
+        '@typescript-eslint/return-await': 'error',
+        'no-unused-expressions': 'off',
+        '@typescript-eslint/no-unused-expressions': 'off',
+        'no-unused-vars': 'off',
+        '@typescript-eslint/no-unused-vars': [
+          'error',
+          {
+            argsIgnorePattern: '^_',
+            varsIgnorePattern: '^ignored',
+            args: 'after-used',
+            ignoreRestSiblings: true,
+          },
+        ],
+        'require-await': 'off',
+        '@typescript-eslint/require-await': 'error',
+      },
+    },
+  ],
 }
diff --git a/es6/best-practices.js b/es6/best-practices.js
@@ -15,5 +15,20 @@ module.exports = {
     'prefer-template': 'error',
     'require-yield': 'error',
     'symbol-description': 'error',
+
+    'no-unused-expressions': 'off',
+    'babel/no-unused-expressions': 'error',
   },
+  overrides: [
+    {
+      files: ['**/*.ts?(x)'],
+      rules: {
+        'no-useless-constructor': 'off',
+        '@typescript-eslint/no-useless-constructor': 'error',
+
+        'babel/no-unused-expressions': 'off',
+        '@typescript-eslint/no-unused-expressions': 'error',
+      },
+    },
+  ],
 }
diff --git a/es6/possible-errors.js b/es6/possible-errors.js
@@ -7,9 +7,16 @@ module.exports = {
     'no-new-symbol': 'error',
     'no-this-before-super': 'error',
 
-    'no-unused-expressions': 'off',
-    'babel/no-unused-expressions': 'error',
     'valid-typeof': 'off',
     'babel/valid-typeof': 'error',
   },
+  overrides: [
+    {
+      files: ['**/*.ts?(x)'],
+      rules: {
+        'no-dupe-class-members': 'off',
+        '@typescript-eslint/no-dupe-class-members': 'error',
+      },
+    },
+  ],
 }
diff --git a/es6/stylistic.js b/es6/stylistic.js
@@ -22,4 +22,13 @@ module.exports = {
     'no-invalid-this': 'off',
     'babel/no-invalid-this': 'error',
   },
+  overrides: [
+    {
+      files: ['**/*.ts?(x)'],
+      rules: {
+        'babel/camelcase': 'off',
+        '@typescript-eslint/camelcase': ['error', {properties: 'always'}],
+      },
+    },
+  ],
 }
diff --git a/possible-errors.js b/possible-errors.js
@@ -41,4 +41,13 @@ module.exports = {
     // variables
     'no-use-before-define': ['error', 'nofunc'],
   },
+  overrides: [
+    {
+      files: ['**/*.ts?(x)'],
+      rules: {
+        'no-use-before-define': 'off',
+        '@typescript-eslint/no-use-before-define': ['error', 'nofunc'],
+      },
+    },
+  ],
 }
diff --git a/stylistic.js b/stylistic.js
@@ -55,4 +55,14 @@ module.exports = {
     // variables
     'init-declarations': 'off',
   },
+  overrides: [
+    {
+      files: ['**/*.ts?(x)'],
+      extends: 'prettier/@typescript-eslint',
+      rules: {
+        'no-array-constructor': 'off',
+        '@typescript-eslint/no-array-constructor': 'error',
+      },
+    },
+  ],
 }